This repository was archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed the CLA |
CLAs look good, thanks! |
i think this is the same as #1028, no? |
It is almost the same. While I have similar changes for setting the timeout via env-vars, I also included a toleration for the OS not deleting a directory quickly enough. I will separate the two and add another PR |
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
It allows setting two environment variables (DEP_CMD_TIMEOUT and DEP_EXP_CMD_TIMEOUT) to control the timeout for external commands to finish.
On slow machines or slow setups (remote FS, or in my case ubuntu on windows) the 10s default are not sufficient.
The change will make dep tolerate incomplete deletions of vendor directories in dependant packages. This is also an attempt to support slower operations.
Do you need help or clarification on anything?
Where should documentation go?
Which issue(s) does this PR fix?
It uses an idea presented in #1065 to circumvent the problem shown there. Does that count as a fix?