This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Added more tests to main_test.go #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased main.go coverage from 12.8% to 21.8% - Added test for `project.makeParams()` - Added an extra test for `findProjectRoot()`
|
Awesome!
…On Tue, Jan 24, 2017 at 5:52 PM Ray Tung ***@***.***> wrote:
Hey all!
It's been a long time coming and thanks for this project!
I came across #41 <#41> and hope to
contribute a small test snippet as my first PR :)
Increased main.go coverage from 12.8% to 21.8%
- Added test for project.makeParams()
- Added an extra test for findProjectRoot()
------------------------------
You can view, comment on, or merge this pull request online at:
#143
Commit Summary
- Added more tests to main_test.go
File Changes
- *M* main_test.go
<https://github.com/golang/dep/pull/143/files#diff-0> (36)
Patch Links:
- https://github.com/golang/dep/pull/143.patch
- https://github.com/golang/dep/pull/143.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#143>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbHXPRThkXDqY4ZD6cXH7sEZyoO-Bks5rVqrvgaJpZM4LtAvm>
.
|
|
LGTM thanks! |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Refactor hashing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all!
It's been a long time coming and thanks for this project!
I came across #41 and hope to contribute a small test snippet as my first PR :)
Increased main.go coverage from 12.8% to 21.8%
project.makeParams()findProjectRoot()