Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

rename hoard to dep #164

Merged
merged 3 commits into from
Jan 26, 2017
Merged

rename hoard to dep #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7ce8dc
rename hoard to deb
rakyll Jan 25, 2017
797b268
fix typo
rakyll Jan 26, 2017
786ff7f
fix memos
rakyll Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ import (

type analyzer struct{}

// TODO: If we decide to support other tools manifest, this is where we would need
// to add that support.
func (a analyzer) DeriveManifestAndLock(path string, n gps.ProjectRoot) (gps.Manifest, gps.Lock, error) {
// TODO: If we decide to support other tools manifest, this is where we would need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit description should also mention that you've adjusted some comments.

// to add that support.
mf := filepath.Join(path, manifestName)
if fileOK, err := isRegular(mf); err != nil || !fileOK {
// Do not return an error, when does not exist
// Do not return an error, when does not exist.
return nil, nil, nil
}
f, err := os.Open(mf)
Expand All @@ -32,12 +32,12 @@ func (a analyzer) DeriveManifestAndLock(path string, n gps.ProjectRoot) (gps.Man
if err != nil {
return nil, nil, err
}
// TODO: no need to return lock til we decide about preferred versions
// https://github.com/sdboyer/gps/wiki/gps-for-Implementors#preferred-versions
// TODO: No need to return lock til we decide about preferred versions, see
// https://github.com/sdboyer/gps/wiki/gps-for-Implementors#preferred-versions.
return m, nil, nil
}

func (a analyzer) Info() (name string, version *semver.Version) {
v, _ := semver.NewVersion("v0.0.1")
return "hoard", v
return "dep", v
}
4 changes: 2 additions & 2 deletions ensure_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func main() {

sysCommit := tg.getCommit("go.googlesource.com/sys")
expectedLock := `{
"memo": "574170053fb14e0ecdd0ec4d8bb3323b901cb98710ac0da175efdf881dd4fb81",
"memo": "57d20ba0289c2df60025bf6127220a5403483251bd5e523a7f9ea17752bd5482",
"projects": [
{
"name": "github.com/Sirupsen/logrus",
Expand Down Expand Up @@ -133,7 +133,7 @@ func main() {
sysCommit := tg.getCommit("go.googlesource.com/sys")
logrusCommit := tg.getCommit("github.com/Sirupsen/logrus")
expectedLock := `{
"memo": "139636a8e035b230b0d40c3beaca066a4fcd9b8577108b1727482af7cb743355",
"memo": "d4a7b45d366ece090464407f4038cdb62a031c29ef3254f197b8a3d5e6993cca",
"projects": [
{
"name": "github.com/Sirupsen/logrus",
Expand Down
2 changes: 1 addition & 1 deletion init_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const Qux = "yo yo!"

sysCommit := tg.getCommit("go.googlesource.com/sys")
expectedLock := `{
"memo": "e5aa3024d5de3a019bf6541029effdcd434538399eb079f432635c8524d31238",
"memo": "668fe45796bc4e85a5a6c0a0f1eb6fab9e23588d1eb33f3a12b2ad5599a3575e",
"projects": [
{
"name": "github.com/Sirupsen/logrus",
Expand Down
2 changes: 1 addition & 1 deletion remove_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func main() {

sysCommit := tg.getCommit("go.googlesource.com/sys")
expectedLock := `{
"memo": "c2d1935d281595034e4afeb49d13981f4210badea72ac78c3eb2ba01f36c3ceb",
"memo": "7769242a737ed497aa39831eecfdc4a1bf59517df898907accc6bdc0f789a69b",
"projects": [
{
"name": "github.com/Sirupsen/logrus",
Expand Down