This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Simplify findProjectRoot #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly the non controversial changes from #11, plus a more to the std lib stub function.
sdboyer
approved these changes
Nov 30, 2016
| return nil, fmt.Errorf("could not open %s: %s", mp, err) | ||
| if os.IsNotExist(err) { | ||
| // TODO: list possible solutions? (dep init, cd $project) | ||
| return nil, fmt.Errorf("no %v found in project root %v", manifestName, p.absroot) |
There was a problem hiding this comment.
nit: is it standard practice to use %v for string placeholders? It works, ofc; I've just always tended to %s.
There was a problem hiding this comment.
I'm interested in hearing what @adg says about this, but %v == "default format", so I generally use it for most things unless I need more control over the format.
zbintliff
added a commit
to zbintliff/dep
that referenced
this pull request
Mar 3, 2017
Simplify findProjectRoot
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Introduce intermediary smcache within the solver
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
Simplify findProjectRoot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the non controversial changes from #11, plus a more to
the std lib stub function.
/cc @sdboyer