Non-existing import path with less side effects #240
Conversation
Using a github.com repository for a fixture intended to not exist has the unfortunate side effect of, at least sometimes, cauisng the tool to hang when prompting the user for a password. Hopefully this'll be improved by using a valid, deducible import path pointing to a nonexistent domain instead.
sdboyer
force-pushed
the
friendlier-notexist
branch
from
c45a0b6 to
271a7d7
Compare
|
Yeah, this doesn't seem to be making it any better 😡 |
|
Seems like the issue isn't so much the password request, but that the goroutine is not collected before the test moves on. So it's a race to see if the test can finish before that thread cleans up. The password request certainly forces the outcome, but the race is still on without one. |
|
I'll try to stare at it and see if I can help, but it is down in the weeds in an architecture I haven't wrapped my head around. Are you comfortable enough with the gps test suite that if I find a fix that doesn't break anything else, it is likely to fly? |
|
I appreciate it, but yeah, it's very far down in the weeds, and while the solver itself is quite well-covered with tests, the source manager is less so. If you've got the time to look at things, it's probably not the ideal place to spend it 😄 |
|
This seems to wholly miss the problem, so I'm just going to close it. |
Using a github.com repository for a fixture intended to not exist has the unfortunate side effect of, at least sometimes, cauisng the tool to hang when prompting the user for a password. Hopefully this'll be improved by using a valid, deducible import path pointing to a nonexistent domain instead.
Fixes #214 (I hope)