This repository was archived by the owner on Sep 9, 2020. It is now read-only.
start of remove #49
Merged
start of remove #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (but thats obvious haha) |
adg
approved these changes
Dec 20, 2016
|
|
||
| func getProjectData(pkgT gps.PackageTree, cpr string, sm *gps.SourceMgr) ( |
There was a problem hiding this comment.
I suggest bundling these return values into a struct (ProjectData? or just Project?). It'll make the declaration and call sites much cleaner.
| } | ||
|
|
||
| for pr, v := range ondisk { | ||
| // That we have to chop off these path prefixes is a symptom of |
adg
approved these changes
Dec 20, 2016
Signed-off-by: Jess Frazelle <[email protected]> do not send in manifest Signed-off-by: Jess Frazelle <[email protected]> setup logging Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what @freeformz and I did!
update #42