This repository was archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Rename [[dependencies]] to [[constraint]] #538
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
required = ["github.com/Masterminds/semver"] | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
branch = "2.x" | ||
name = "github.com/Masterminds/semver" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/Masterminds/vcs" | ||
version = "^1.11.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
branch = "master" | ||
name = "github.com/pelletier/go-toml" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/pkg/errors" | ||
version = ">=0.8.0, <1.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,9 +12,10 @@ | |
## or in a dependency. | ||
# ignored = ["github.com/user/project/badpkg"] | ||
|
||
## Dependencies define constraints on dependent projects. They are respected by | ||
## Constraints are rules for how directly imported projects | ||
## may be incorporated into the depgraph. They are respected by | ||
## dep whether coming from the Gopkg.toml of the current project or a dependency. | ||
# [[dependencies]] | ||
# [[constraint]] | ||
## Required: the root import path of the project being constrained. | ||
# name = "github.com/user/project" | ||
# | ||
|
@@ -27,12 +28,12 @@ | |
## Optional: an alternate location (URL or import path) for the project's source. | ||
# source = "https://github.com/myfork/package.git" | ||
|
||
## Overrides have the same structure as [[dependencies]], but supercede all | ||
## [[dependencies]] declarations from all projects. Only the current project's | ||
## [[overrides]] are applied. | ||
## Override have the same structure as [[constraint]], but supercede all | ||
## [[constraint]] declarations from all projects. Only the current project's | ||
## [[override]] is applied. | ||
## | ||
## Overrides are a sledgehammer. Use them only as a last resort. | ||
# [[overrides]] | ||
## Override is a sledgehammer. Use them only as a last resort. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Override is a sledgehammer. Use it only as a last resort." or "Overrides are a sledgehammer. Use them only as a last resort." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The latter, please 😄 |
||
# [[override]] | ||
## Required: the root import path of the project being constrained. | ||
# name = "github.com/user/project" | ||
# | ||
|
@@ -51,6 +52,6 @@ | |
|
||
|
||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "^1.0.0" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/empty/case2/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "~0.8.0" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/empty/case2/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "~0.8.0" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/empty/case3/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
ignored = ["github.com/sdboyer/deptestdos"] | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
branch = "master" | ||
name = "github.com/sdboyer/deptest" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/empty/case3/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
ignored = ["github.com/sdboyer/deptestdos"] | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
branch = "master" | ||
name = "github.com/sdboyer/deptest" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/update/case1/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "~0.8.0" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/update/case1/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "~0.8.0" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/update/case2/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "~0.8.0" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/ensure/update/case2/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "~0.8.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
version = "^2.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
branch = "master" | ||
name = "github.com/sdboyer/deptest" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" |
2 changes: 1 addition & 1 deletion
2
cmd/dep/testdata/harness_tests/init/skip-hidden/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "^1.0.0" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/force/case1/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/force/case1/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/specific/case1/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/specific/case1/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/specific/case2/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/specific/case2/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/unused/case1/final/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
6 changes: 3 additions & 3 deletions
6
cmd/dep/testdata/harness_tests/remove/unused/case1/initial/Gopkg.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/not/used" | ||
version = "2.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = ">=0.8.0, <1.0.0" | ||
|
||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptestdos" | ||
revision = "a0196baa11ea047dd65037287451d36b861b00ea" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "^0.8.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[[dependencies]] | ||
[[constraint]] | ||
name = "github.com/sdboyer/deptest" | ||
version = "^0.8.0" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Override" should probably be "Overrides" here to be grammatically correct and consistent with line 15.
Or, this sentence could be "Override has ..." and line 15 can be changed to "Constraint is a rule ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, the former is preferred, primarily for consistency.