This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Restore warning logging #545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves loggers.go to project root under package dep - Changes all the Loggers references to refer to dep.Loggers.
- Removes Loggers injection from all the functions that required loggers and use Ctx.Loggers instead.
darkowlzz
force-pushed
the
531-restore-warning-logging
branch
from
43ef1f7 to
828e769
Compare
|
Gonna close this in favor of #544 - I that's OK, @darkowlzz - I've got a different approach I'd like to see this take, but I'm hoping to reserve your focus for the ongoing work with the new spec 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loggers.goout of cmd/dep todeppackage.Loggersfrom all the functions and use Loggers fromCtxLoggerstoreadManifest()for warning logging.Fixes #531