Include more error context in deduction failures#561
Conversation
|
So, I'm unsure about this. We don't want to double-wrap these errors, and while it's more convenient to wrap them in the central location that |
|
@sdboyer I haven't heard that advice. I just use errors.Wrap to build the stack of errors so it can be printed back in a way that makes the error clear... Are you saying you'd prefer this error? |
|
@spenczar i'm honestly not sure about it myself - @davecheney, did i read this somewhere, or am I pulling this out of my ass - is it suboptimal to I think just the dial error may be a bit lower-level than we're looking for, but...well, honestly, I mostly just want us to be consistent. |
|
I'm gonna call this fine as incremental progress, and click the big green button 😄 |
More liberal use of
errors.Wrapgives more complete output, like this:This could be improved, readability-wise, but the first step is to preserve the error information up to the caller.
Fixes #556.