Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Update mastermind semver #579

Merged
merged 5 commits into from
May 18, 2017

Conversation

xmattstrongx
Copy link
Contributor

Initial start of PR for #562 . Integration tests failing. Looking in to them

@xmattstrongx xmattstrongx force-pushed the update_mastermind_semver branch from 256c04e to c871d11 Compare May 14, 2017 17:53
@xmattstrongx
Copy link
Contributor Author

xmattstrongx commented May 14, 2017

All checks green, though I am not confident on the resolution. Changed an failing deep equals check on an error type to a check of the equivalence of the error type's strings. Also modified test data. Unclear what the mode in the test hardness cases is derived from.

@sdboyer
Copy link
Member

sdboyer commented May 18, 2017

Ahh, ok, yes - I now remember why this is happening the way it is. The old version of semver we were on had only halfway converted the below-1.0.0 handling of carets - the parser was still doing the old thing, but the stringifier had the new logic. As a result, ^0.8.0 would be parsed as "greater than or equal to 0.8.0 and less than 1.0.0" - but in the new model, that stringifies to >=0.8.0, < 1.0.0.

This all happens in the test output as it does because we prepend the caret.

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants