Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Add temporary solution to avoid a panic #630

Merged
merged 1 commit into from
May 23, 2017

Conversation

nathanielc
Copy link
Contributor

This is a temporary fix to avoid the panic caused in #367 and #357

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nathanielc
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this - just a little nit 😄

@@ -627,6 +627,14 @@ func wmToReach(workmap map[string]wm, backprop bool) (ReachMap, map[string]*Prob
// an empty path here.

fromErr := errmap[from]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's use the two-return form of map lookups here, and check against that for this ase, rather than checking if fromErr == nil.

@nathanielc nathanielc force-pushed the nc-bandaid-issue#367 branch from ba03647 to d9cb399 Compare May 23, 2017 17:11
@nathanielc nathanielc force-pushed the nc-bandaid-issue#367 branch from d9cb399 to 263c6df Compare May 23, 2017 17:12
@sdboyer sdboyer merged commit 3f525d0 into golang:master May 23, 2017
@sdboyer
Copy link
Member

sdboyer commented May 23, 2017

thanks! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants