This repository was archived by the owner on Sep 9, 2020. It is now read-only.
internal/fs: IsRegular returns an error on any non regular file #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates #632 IsRegular would previously return true if any file that was _not_ a directory were presented. With this change IsRegular rejects any file with a mode bit in the os.ModeType bitset--only regular files will pass this test.
jmank88
approved these changes
May 24, 2017
|
The functionality here is obviously correct, so I'm not worried about testing for that. Some basic regression tests might not be a terrible thing to have. More important, probably is, improving the godoc to more precisely describe the func's behavior. |
|
bump - just some small changes here, then we can merge |
|
closing/reopening to rerun tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #632
IsRegular would previously return true if any file that was not a
directory were presented. With this change IsRegular rejects any file
with a mode bit in the os.ModeType bitset--only regular files will pass
this test.