Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

internal/fs: update error message when rename fallback fails #655

Merged
merged 2 commits into from
May 26, 2017

Conversation

ibrasho
Copy link
Collaborator

@ibrasho ibrasho commented May 25, 2017

Would clarify errors like (from #651):

safe write of manifest and lock: second attempt failed: cannot rename /tmp/dep666066408/vendor to /home/ser/workspace/src/foo/vendor: read /tmp/dep666066408/vendor/github.com/prometheus/procfs/fixtures/self: is a directory

to become:

safe write of manifest and lock: rename fallback failed: cannot rename /tmp/dep666066408/vendor to /home/ser/workspace/src/foo/vendor: copying file failed: read /tmp/dep666066408/vendor/github.com/prometheus/procfs/fixtures/self: is a directory

@sdboyer
Copy link
Member

sdboyer commented May 26, 2017

All this multilayer error wrapping seems like a code smell to me, but i don't have a well-formed opinion about what we'd do instead, so... 😄

@sdboyer sdboyer merged commit e241dcf into golang:master May 26, 2017
@ibrasho ibrasho deleted the update-error branch June 15, 2017 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants