Skip to content

slices: relax the constraints to type whose underlying type is slice #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SilverRainZ
Copy link

Like what we done in exp/maps, exp/slices would be better to accept a
type whose underlying type is slice.

Due to golang/go#48619, constraints of quickSortOrdered and its
related functions are not changed. So cast S to []E for now.

Like what we done in exp/maps, exp/slices would be better to accept a
type whose underlying type is slice.

Due to golang/go#48619, constraints of quickSortOrdered and its
related functions are not changed. So cast S to []E for now.
@gopherbot
Copy link
Contributor

This PR (HEAD: 41dd9ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/381274 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/381274.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from 张盛宇:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/381274.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/381274.
After addressing review feedback, remember to publish your drafts!

@SilverRainZ SilverRainZ closed this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants