Skip to content
This repository was archived by the owner on Jan 16, 2021. It is now read-only.

Make godoc.org HTTPS-only #304

Closed
jleclanche opened this issue Aug 22, 2015 · 5 comments · Fixed by #322
Closed

Make godoc.org HTTPS-only #304

jleclanche opened this issue Aug 22, 2015 · 5 comments · Fixed by #322

Comments

@jleclanche
Copy link

Is there a reason why http://godoc.org doesn't 301 to the https version? SSL is set up and works perfectly, seems like an easy fix.

@jleclanche
Copy link
Author

Had I noticed a few days earlier I could've filed a nicely self-referential issue there...

@dmitshur
Copy link
Member

Sounds like a good idea.

@dmitshur
Copy link
Member

Had I noticed a few days earlier I could've filed a nicely self-referential issue there...

Haha, just got it. 😀

@adg adg changed the title Add 301s to https://... Make godoc.org HTTPS-only Aug 24, 2015
@adg
Copy link
Contributor

adg commented Aug 24, 2015

We'd want to set up HSTS in the SSL cert also.

@adg
Copy link
Contributor

adg commented Sep 25, 2015

Should be pretty easy to do the server-side part of this with a change similar to this one: golang/tools@40b1b21#diff-871153e4ac7a351c1a6c61e5013b51c8R36

jmhodges added a commit to jmhodges/gddo that referenced this issue Sep 25, 2015
Redirect HTTP links to HTTPS and set HSTS correctly.

Provides command-line flags to help out installations running on
non-standard ports and default appengine correctly.

Fixes golang#304.
@jmhodges jmhodges mentioned this issue Sep 25, 2015
jmhodges added a commit to jmhodges/gddo that referenced this issue Sep 25, 2015
Redirect HTTP links to HTTPS and set HSTS correctly.

Provides command-line flags to help out installations running on
non-standard ports and default appengine correctly.

Fixes golang#304.
jmhodges added a commit to jmhodges/gddo that referenced this issue Sep 25, 2015
Redirect HTTP links to HTTPS and set HSTS correctly.

Fixes golang#304.
jmhodges added a commit to jmhodges/gddo that referenced this issue Sep 25, 2015
Redirect HTTP links to HTTPS and set HSTS correctly.

This is specific to the godoc.org set up (with nginx passing a X-Scheme
header back) and without fixing up api.godoc.org.

Fixes golang#304.
jmhodges added a commit to jmhodges/gddo that referenced this issue Sep 25, 2015
Redirect HTTP links to HTTPS and set HSTS correctly.

This is specific to the godoc.org set up (with nginx passing a X-Scheme
header back) and without fixing up api.godoc.org.

Fixes golang#304.
@adg adg closed this as completed in #325 Sep 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants