Skip to content

Commit 1d400cd

Browse files
andiggopherbot
authored andcommitted
encoding/json: use reflect.Value.IsZero
IsZero does the same thing, using this rather than writing it again. Follow-up to #63519 Change-Id: I93768874052935dd7cb58804f22748091bcc3ef7 GitHub-Last-Rev: dfbc6ed GitHub-Pull-Request: #63540 Reviewed-on: https://go-review.googlesource.com/c/go/+/535415 Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Joseph Tsai <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent d1cb248 commit 1d400cd

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

src/encoding/json/encode.go

+6-10
Original file line numberDiff line numberDiff line change
@@ -307,16 +307,12 @@ func isEmptyValue(v reflect.Value) bool {
307307
switch v.Kind() {
308308
case reflect.Array, reflect.Map, reflect.Slice, reflect.String:
309309
return v.Len() == 0
310-
case reflect.Bool:
311-
return v.Bool() == false
312-
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
313-
return v.Int() == 0
314-
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
315-
return v.Uint() == 0
316-
case reflect.Float32, reflect.Float64:
317-
return v.Float() == 0
318-
case reflect.Interface, reflect.Pointer:
319-
return v.IsNil()
310+
case reflect.Bool,
311+
reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64,
312+
reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr,
313+
reflect.Float32, reflect.Float64,
314+
reflect.Interface, reflect.Pointer:
315+
return v.IsZero()
320316
}
321317
return false
322318
}

0 commit comments

Comments
 (0)