encoding/xml: use reflect.Value.IsZero #63519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

apocelipes wants to merge 1 commit into golang:master from apocelipes:feat-using-iszero

Contributor

apocelipes commented Oct 12, 2023

IsZero does the same thing, using this rather than writing it again.


          encoding/xml: use reflect.Value.IsZero

1d5fd10

IsZero does the same thing, use this than write it again.

Contributor

gopherbot commented Oct 12, 2023

This PR (HEAD: 1d5fd10) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/534935.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Oct 12, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from kyose chang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from Ian Lance Taylor:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-10-12T16:45:05Z","revision":"b786d6d8e9906bf62c4b0f90a98510e62ce78938"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          encoding/xml: use reflect.Value.IsZero

cc13161

IsZero does the same thing, using this rather than writing it again.

Change-Id: I62810ac2d1a6e189feac03b022c8931fb6993e19
GitHub-Last-Rev: 1d5fd10
GitHub-Pull-Request: #63519
Reviewed-on: https://go-review.googlesource.com/c/go/+/534935
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>

Contributor

gopherbot commented Oct 12, 2023

Message from Dmitri Shuralyov:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/534935.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2023

This PR is being closed because golang.org/cl/534935 has been merged.

gopherbot closed this

apocelipes deleted the feat-using-iszero branch

October 13, 2023 11:13

Contributor

andig commented Oct 13, 2023

@apocelipes do you plan to open the same PR for encoding/json?

Contributor Author

apocelipes commented Oct 13, 2023 •

edited

Loading

@apocelipes do you plan to open the same PR for encoding/json?

Not yet. You can take it if you want. :) @andig

This was referenced Oct 14, 2023

encoding/json: use reflect.Value.IsZero #63533

Closed

encoding/json: use reflect.Value.IsZero #63540

Closed

gopherbot pushed a commit that referenced this pull request


          encoding/json: use reflect.Value.IsZero

1d400cd

IsZero does the same thing, using this rather than writing it again.

Follow-up to #63519

Change-Id: I93768874052935dd7cb58804f22748091bcc3ef7
GitHub-Last-Rev: dfbc6ed
GitHub-Pull-Request: #63540
Reviewed-on: https://go-review.googlesource.com/c/go/+/535415
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Joseph Tsai <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

yunginnanet pushed a commit to yunginnanet/go that referenced this pull request


          encoding/xml: use reflect.Value.IsZero

d9ede27

IsZero does the same thing, using this rather than writing it again.

Change-Id: I62810ac2d1a6e189feac03b022c8931fb6993e19
GitHub-Last-Rev: 1d5fd10
GitHub-Pull-Request: golang#63519
Reviewed-on: https://go-review.googlesource.com/c/go/+/534935
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>

yunginnanet pushed a commit to yunginnanet/go that referenced this pull request


          encoding/json: use reflect.Value.IsZero

d1c1597

IsZero does the same thing, using this rather than writing it again.

Follow-up to golang#63519

Change-Id: I93768874052935dd7cb58804f22748091bcc3ef7
GitHub-Last-Rev: dfbc6ed
GitHub-Pull-Request: golang#63540
Reviewed-on: https://go-review.googlesource.com/c/go/+/535415
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Joseph Tsai <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet