Skip to content

Commit 32b9e56

Browse files
stefanbodeke-em
authored andcommitted
net/url: fail TestParseErrors test when getting an unwanted error
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does. Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1 GitHub-Last-Rev: c33f984 GitHub-Pull-Request: #32954 Reviewed-on: https://go-review.googlesource.com/c/go/+/185080 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent b963149 commit 32b9e56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/net/url/url_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1456,7 +1456,7 @@ func TestParseErrors(t *testing.T) {
14561456
continue
14571457
}
14581458
if err != nil {
1459-
t.Logf("Parse(%q) = %v; want no error", tt.in, err)
1459+
t.Errorf("Parse(%q) = %v; want no error", tt.in, err)
14601460
}
14611461
}
14621462
}

0 commit comments

Comments
 (0)