net/url: fail TestParseErrors test when getting an unwanted error #32954
Conversation
…rned mark test as failed
googlebot
added
the
cla: yes
|
I noticed this when adding test cases for #29384 |
|
This PR (HEAD: 310ad6c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/185080 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: fffe554) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/185080 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 3afe2c8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/185080 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: c33f984) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/185080 to see it. Tip: You can toggle comments from me using the |
|
Message from Emmanuel Odeke: Patch Set 4: Run-TryBot+1 Code-Review+2 Thank you for this change Stefan and welcome to the Go project! This has been in since CL 11414. LGTM, but we are currently in a code freeze so when Go1.13 I shall submit it. R=Go1.14 Please don’t reply on this GitHub thread. Visit golang.org/cl/185080. |
|
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=aa94f221 Please don’t reply on this GitHub thread. Visit golang.org/cl/185080. |
|
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/185080. |
|
This PR is being closed because golang.org/cl/185080 has been merged. |
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does. Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1 GitHub-Last-Rev: c33f984 GitHub-Pull-Request: #32954 Reviewed-on: https://go-review.googlesource.com/c/go/+/185080 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does. Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1 GitHub-Last-Rev: c33f984 GitHub-Pull-Request: golang#32954 Reviewed-on: https://go-review.googlesource.com/c/go/+/185080 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does. Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1 GitHub-Last-Rev: c33f984 GitHub-Pull-Request: golang#32954 Reviewed-on: https://go-review.googlesource.com/c/go/+/185080 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
The TestParseErrors test function was not strict with unwanted errors
received from url.Parse(). It was not failing in such cases, now it does.