Skip to content

cmd/pprof: tool should nuke temporary directories when done #13863

@dsnet

Description

@dsnet

Using go1.5

Calling web on go tool pprof creates a temporary directory, but forgets to clean it up.

Currently, I see:

rawr@carbonite: /tmp $ ll pprof-*
pprof-258052144:
total 0

pprof-316027049:
total 0

pprof-394800818:
total 0

pprof-675261706:
total 0

pprof-871857163:
total 0

...

I expect to see:

rawr@carbonite: /tmp $ ll pprof-*
ls: cannot access pprof-*: No such file or directory

Probably just a missing defer in cmd/pprof/internal/commands/commands.go.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions