Skip to content

all: spelling inconsistency for networking terms #17613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikioh opened this issue Oct 26, 2016 · 9 comments
Closed

all: spelling inconsistency for networking terms #17613

mikioh opened this issue Oct 26, 2016 · 9 comments
Labels
Documentation Issues describing a change to documentation. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

mikioh commented Oct 26, 2016 •
edited
Loading

Some packages use hostname and others host name. The worst is the net package which uses both. It might be better to align to host name defined in https://tools.ietf.org/html/rfc7719.

Host name: This term and its equivalent, "hostname", have been
widely used but are not defined in [RFC1034], [RFC1035], [RFC1123], or [RFC2181].
@mikioh mikioh added the Documentation Issues describing a change to documentation. label Oct 26, 2016
@as
Copy link
Contributor

as commented Oct 27, 2016

Where is host name defined in RFC 7791?

https://tools.ietf.org/html/rfc7791

@mikioh
Copy link
Contributor Author

mikioh commented Oct 27, 2016

s/7791/7719/g

@quentinmit
Copy link
Contributor

I would instead encourage us to avoid the term "hostname" unless it specifically refers to the operating system's notion of hostname. (As RFC 7719 mentions, the hostname often does not include the domain part.)

@quentinmit quentinmit added this to the Go1.8Maybe milestone Oct 28, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 28, 2016
@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Nov 11, 2016
@mikioh
Copy link
Contributor Author

mikioh commented Dec 21, 2016

@mdempsky tackled this issue a bit for Lookup functions and used the term host for host names, the term name for domain names in CL 34650; just FYI.

@bradfitz bradfitz modified the milestones: Go1.9Maybe, Go1.9 May 22, 2017
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/34875 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/34876 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/34879 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 22, 2017
@cixtor
net: update documentation on Dial and its variants
7e63ce6 
This change clarifies the documentation on Dial and its variants to
avoid unnecessary confusion about how the arguments for the connection
setup functions are used to make connections.

Also replaces "name" or "hostname" with "host name" when the term
implies the use of DNS.

Updates #17613.
Fixes #17614.
Fixes #17738.
Fixes #17956.
Updates #18806.

Change-Id: I6adb3f2ae04a3bf83b96016ed73d8e59926f3e8a
Reviewed-on: https://go-review.googlesource.com/34875
Reviewed-by: Ian Lance Taylor <[email protected]>
gopherbot pushed a commit that referenced this issue Jun 22, 2017
@cixtor
net: update documentation on Listen and ListenPacket
424b065 
This change clarifies the documentation on Listen and ListenPacket to
avoid unnecessary confusion about how the arguments for the connection
setup functions are used to make connections.

Also replaces "name" or "hostname" with "host name" when the term
implies the use of DNS.

Updates #17613.
Updates #17614.
Updates #17615.
Fixes #17616.
Updates #17738.
Updates #17956.

Change-Id: I0bad2e143207666f2358d397fc076548ee6c3ae9
Reviewed-on: https://go-review.googlesource.com/34876
Reviewed-by: Ian Lance Taylor <[email protected]>
gopherbot pushed a commit that referenced this issue Jun 22, 2017
@cixtor
net: update documentation on Resolve{TCP,UDP,IP,Unix}Addr
d23064d 
This change clarifies the documentation on
Resolve{TCP,UDP,IP,Unix}Addr to avoid unnecessary confusion about how
the arguments are used to make end point addresses.

Also replaces "name" or "hostname" with "host name" when the term
implies the use of DNS.

Updates #17613.

Change-Id: Id6be87fe2e4666eecd5b92f18ad8b9a6c50a2bd6
Reviewed-on: https://go-review.googlesource.com/34879
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/49750 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue Jul 18, 2017
@danicat @bradfitz
net: replaces "hostname" with "host name" in the proxy package
5d0d709 
Updates golang/go#17613

Change-Id: I0b272c19c263f20084a936b5122bb3cfebacc752
Reviewed-on: https://go-review.googlesource.com/49750
Reviewed-by: Brad Fitzpatrick <[email protected]>
@bradfitz bradfitz modified the milestones: Go1.10, Go1.9Maybe Jul 24, 2017
@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 28, 2017
@bradfitz bradfitz modified the milestones: Go1.11, Unplanned May 18, 2018
@seankhliao
Copy link
Member

seankhliao commented Mar 22, 2025 •
edited
Loading

This looks like it was all done, the remaining references to hostname are for identifiers in the code the comments describe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
7 participants
@bradfitz @mikioh @rsc @quentinmit @as @gopherbot @seankhliao