net/http: dubious code in TestServeMuxHandlerRedirects

[dominikh]

The test TestServeMuxHandlerRedirects in net/http/serve_test.go looks dubious. The for tries > 0 loop will execute exactly once – tries starts at 1, gets decremented once at the bottom of the loop, and there is no path that would skip the decrement and execute the loop again. Similarly, the check if tries < 0 can never be true – tries will either be its initial value of 1, or the once-decremented value 0.

/cc @bradfitz

[bradfitz]

@minux, looks like you wrote this code over three years ago in 716a409

You want to take a look?

[bradfitz]

Marking Go 1.9, but Go 1.8 is fine too if somebody wants to look into it.

[gopherbot]

CL https://golang.org/cl/33654 mentions this issue.