Skip to content

1.8: merge CL 35956 to 1.8 branch #18870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianlancetaylor opened this issue Jan 31, 2017 · 2 comments
Closed

1.8: merge CL 35956 to 1.8 branch #18870

ianlancetaylor opened this issue Jan 31, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@ianlancetaylor
Copy link
Contributor

We should merge https://golang.org/cl/35956, fixing issue #18845, to the 1.8 branch before the final 1.8 release.
@ianlancetaylor ianlancetaylor added this to the Go1.8 milestone Jan 31, 2017
gopherbot pushed a commit that referenced this issue Feb 2, 2017
@ALTree @bradfitz
[release-branch.go1.8] testing: stop timeout-timer after running tests
4707045 
Fixes #18845

Fixes #18870 (Go 1.8 backport)

Change-Id: Icdc3e2067807781e42f2ffc94d1824aed94d3713
Reviewed-on: https://go-review.googlesource.com/35956
Run-TryBot: Alberto Donizetti <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
(cherry picked from commit 7d8bfdd)
Reviewed-on: https://go-review.googlesource.com/36125
@LionNatsu
Copy link
Contributor

Wow, why is the issue still opening after 'Fixes #id' in commit message?

@ianlancetaylor
Copy link
Contributor Author

I don't know. Closing now.

@golang golang locked and limited conversation to collaborators Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
3 participants
@ianlancetaylor @LionNatsu @gopherbot