-
Notifications
You must be signed in to change notification settings - Fork 18k
unicode: support version 10 #21471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
\cc @mpvl |
Is there anything that needs to be done here aside from updating the tables? It seems like the IDNA changes aren't relevant to Go, and Go doesn't do collation, so it should just be a matter of updating the tables. I did this before realizing the bug was already assigned, but here's the commit in case anyone wants it: Manishearth@dcb8a6f |
@Manishearth The repositories under https://godoc.org/golang.org/x/text might be affected, too. So I hope @mpvl will sort this out or can at least provide a todo list for interested contributors. |
net/http uses http2 uses idna. It is vendored so it matters. The IDNA change was quite substantial so 1.10 it will be. |
Change https://golang.org/cl/63791 mentions this issue: |
This also includes an update of the IDNA algorithm. Some of the definitions of the algorithm changed along with the data, so it is not possible to split this up in separate CLs. See Issue golang/go#21471. The IDNA change is an update to the interpretation of the RFC by UTS golang/go#46, which affects the bidi rule. Also the interpretation of empty labels has been sharpened. The following files have manual changes (all related to IDNA): - secure/precis/enforce_test.go - secure/bidirule/bidirule.go - secure/bidirule/bidirule_test.go - internal/export/idna/idna.go - internal/export/idna/idna_test.go Change-Id: I4365787c3714b2fa392e7b8ae70b3b446637935c Reviewed-on: https://go-review.googlesource.com/63791 Run-TryBot: Marcel van Lohuizen <[email protected]> Reviewed-by: Nigel Tao <[email protected]>
Change https://golang.org/cl/63951 mentions this issue: |
Change https://golang.org/cl/63953 mentions this issue: |
Generated from x/text. Significant changes in the interpretation of the Bidi rule as well as sharpening of the leading dot rules, among other things. Issue golang/go#21471 Change-Id: I8649a4090e2bc530aad4412210a3de344fb2eab6 Reviewed-on: https://go-review.googlesource.com/63951 Run-TryBot: Marcel van Lohuizen <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Nigel Tao <[email protected]>
Also includes all derived values as well as vendored packages. Generated by running UNICODE_VERSION=10.0.0 go generate in golang.org/x/text and modified by hand to add the tests and entries in next.txt for new script and properties. Closes Issue #21471 Change-Id: I1d10ee3887bd1fd3d5a756ee0d04bd6ec2814ba1 Reviewed-on: https://go-review.googlesource.com/63953 Run-TryBot: Marcel van Lohuizen <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Andrew Bonventre <[email protected]>
see http://blog.unicode.org/2017/06/announcing-unicode-standard-version-100.html for the announcement and further information about what changed.
What version of Go are you using (
go version
)?go version go1.9rc2 linux/amd64
What operating system and processor architecture are you using (
go env
)?GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ioe/sources/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/user/1000/go-build705652549=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
What did you do?
println(unicode.Version)
as in https://play.golang.org/p/k69zvpQ97S
What did you expect to see?
10.0.0
What did you see instead?
9.0.0
The text was updated successfully, but these errors were encountered: