vendor/golang.org/x/arch/arm64/arm64asm: Go 1.10.beta1: test failures

[cznic]

What version of Go are you using (go version)?

go version devel +9ce6b5c2ed Thu Dec 7 17:38:51 2017 +0000 linux/amd64 (Go 1.10beta1)

Does this issue reproduce with the latest release?

yes (go version devel +f3f507b2d8 Fri Dec 22 21:13:38 2017 +0000 linux/amd64).

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jnml/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jnml"
GORACE=""
GOROOT="/home/jnml/go"
GOTMPDIR=""
GOTOOLDIR="/home/jnml/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build340000711=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Invoked all.bash.

What did you expect to see?

No failures.

What did you see instead?

....
FAIL	cmd/vendor/golang.org/x/arch/arm64/arm64asm	2.976s
...

Full log attached.

fail.log.tar.gz

[mvdan]

Please update the issue title with what package and test failed (on mobile atm).

[cznic]

The failing package is cmd/vendor/golang.org/x/arch/arm64/arm64asm. The failed tests are

• --- FAIL: TestObjdumpARM64Testdata (0.46s)
• --- FAIL: TestObjdumpARM64Cond (1.40s)
• --- FAIL: TestObjdumpARM64 (1.00s)

[bradfitz]

From the log:

--- FAIL: TestObjdumpARM64Testdata (0.46s)
	ext_test.go:195: decode(573093da) = "csinv x23, x2, x19, cc", 4, want "csinv x23, x2, x19, cc // cc = lo, ul, last", 4
		
	ext_test.go:195: decode(5714291e) = "fccmpe s2, s9, #0x7, ne", 4, want "fccmpe s2, s9, #0x7, ne // ne = any", 4
		
	ext_test.go:195: decode(46bb5c7a) = "ccmp w26, #0x1c, #0x6, lt", 4, want "ccmp w26, #0x1c, #0x6, lt // lt = tstop", 4
		
	ext_test.go:195: decode(ec579f9a) = "cset x12, mi", 4, want "cset x12, mi // mi = first", 4
		
	ext_test.go:195: decode(938591da) = "csneg x19, x12, x17, hi", 4, want "csneg x19, x12, x17, hi // hi = pmore", 4
		
	ext_test.go:195: decode(ed8f7a1e) = "fcsel d13, d31, d26, hi", 4, want "fcsel d13, d31, d26, hi // hi = pmore", 4
		
	ext_test.go:195: decode(e048533a) = "ccmn w7, #0x13, #0x0, mi", 4, want "ccmn w7, #0x13, #0x0, mi // mi = first", 4
		
	ext_test.go:195: decode(c8b56a1e) = "fccmp d14, d10, #0x8, lt", 4, want "fccmp d14, d10, #0x8, lt // lt = tstop", 4
		
	ext_test.go:195: decode(020a567a) = "ccmp w16, #0x16, #0x2, eq", 4, want "ccmp w16, #0x16, #0x2, eq // eq = none", 4
		
	ext_test.go:195: decode(a6985afa) = "ccmp x5, #0x1a, #0x6, ls", 4, want "ccmp x5, #0x1a, #0x6, ls // ls = plast", 4
		
	ext_test.go:195: decode(6a938c5a) = "csinv w10, w27, w12, ls", 4, want "csinv w10, w27, w12, ls // ls = plast", 4
		
	ext_test.go:195: decode(a64f6d1e) = "fcsel d6, d29, d13, mi", 4, want "fcsel d6, d29, d13, mi // mi = first", 4

[cherrymui]

What version of objdump do you have on the machine? Probably this is a different version that outputs slightly differently than what the test expects.

It seems the difference is only the "comments" // cc = .... Maybe we should strip the comments before comparing the output.

cc @williamweixiao

[cznic]

$  objdump --version
GNU objdump (GNU Binutils; openSUSE Leap 42.3) 2.29.1
Copyright (C) 2017 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty.
$

[gopherbot]

Change https://golang.org/cl/85476 mentions this issue: x/arch/arm64: strip comments of objdump 2.29

[williamweixiao]

@cznic Could you please apply CL: https://golang.org/cl/85476 on your environment (I need to fix it on arch repo first then golang repo. But you can directly copy the changes to golang repo for test)?

[cznic]

Works just fine here, details attached.

pass.log.tar.gz

[gopherbot]

Change https://golang.org/cl/85495 mentions this issue: cmd/vendor/golang.org/x/arch: revendor at commit 98fd8d9

[gopherbot]

Change https://golang.org/cl/85615 mentions this issue: cmd/vendor/golang.org/x/arch: pull latest updates from x repo (commit 98fd8d9)