Skip to content

test: locklinear.go constantly failing on arm5 builder #24221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ALTree opened this issue Mar 2, 2018 · 5 comments
Closed

test: locklinear.go constantly failing on arm5 builder #24221

ALTree opened this issue Mar 2, 2018 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@ALTree
Copy link
Member

ALTree commented Mar 2, 2018

the locklinear test (previously featured in #19276) is reliably failing on the linux-arm-arm5spacemonkey builder since... forever: https://build.golang.org.

I don't know if the test is too strict or the builder is just incapable of running it fast enough, but in any case is not useful to have a builder that always fails on the same test. Maybe the test should just be skipped there.

cc @bradfitz @aclements

@ALTree ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) labels Mar 2, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Mar 2, 2018

I'd just skip it.

@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 20, 2018
@rsc
Copy link
Contributor

rsc commented Mar 26, 2018

Just skip it.

@spf13 spf13 added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 26, 2018
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 26, 2018
@andybons andybons added this to the Unreleased milestone Mar 26, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/104535 mentions this issue: test: skip locklinear's lockmany test for now

gopherbot pushed a commit that referenced this issue Apr 5, 2018
Since it's been reliably failing on one of the linux-arm builders
(arm5spacemonkey) for a long time.

Updates #24221.

Change-Id: I8fccc7e16631de497ccc2c285e510a110a93ad95
Reviewed-on: https://go-review.googlesource.com/104535
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mvdan
Copy link
Member

mvdan commented Apr 5, 2018

The test is skipped on all arm5 builders now. The builder now seems to be hitting other issues like #24695.

Should we keep this issue open until the builder goes green? Is there an underlying issue to be fixed, or is it not worth the effort to fix this test on the arm5 builder?

@aclements
Copy link
Member

Since this issue is specific to locklinear and that should be fixed now, we should close this (and track further problems as other issues). Thanks!

@golang golang locked and limited conversation to collaborators Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

8 participants