x/net/proxy: Dialer.Dial doesn't have a timeout

[Varunram]

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10.1 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

macOS 10.13, amd64

What did you do?

Try to use proxy.SOCKS5 for making connection via a proxy

What did you expect to see?

proxy.Dialer.Dial should have a timeout

net.Dial has a timeout but proxy.Dialer.Dial doesn't have a timeout. I guess behaviour is similar in both cases, so it would be nice to have a timeout for proxy as well.

Would be nice if there is a workaround as well, would be open to trying them out. Thanks!

[andybons]

@mikioh

[wrfly]

Any updates?

[DeadNumbers]

Try this

func Client(socks, addr string) (net.Conn, error) {
	dialer, err := proxy.SOCKS5("tcp", socks, nil, &net.Dialer{Timeout: 3 * time.Second})
	if err != nil {
		return nil, err
	}
	conn, err := dialer.Dial("tcp", addr)
	if err != nil {
		return nil, err
	}
	return conn, err
}

[gopherbot]

Change https://golang.org/cl/168921 mentions this issue: proxy: add Dial (with context)