Repository navigation
net/http: SameSite description is grammatically incorrect #28244
Description
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go 1.11.x
Does this issue reproduce with the latest release?
The issue is with the documentation for net/http/SameSite documentation which was added in go 1.11
What did you expect to see?
I believe the following captures the intended description, without restructuring it too significantly
SameSite allows a server to define a cookie attribute making it impossible for the browser to send this cookie along with cross-site requests. The main goal is to mitigate the risk of cross-origin information leakage and provide some protection against cross-site request forgery attacks.
What did you see instead?
SameSite allows a server define a cookie attribute making it impossible to the browser send this cookie along with cross-site requests. The main goal is mitigate the risk of cross-origin information leakage, and provides some protection against cross-site request forgery attacks.
Activity
[-]net/http/SameSite: Description is grammatically incorrect[/-][+]net/http: SameSite description is grammatically incorrect[/+]bradfitz commentedon Oct 17, 2018
Want to send a change?
taylorza commentedon Oct 17, 2018
@bradfitz, I will send the change in.
mbj36 commentedon Oct 18, 2018
@bradfitz I am new contributor to golang and i am slightly confused about the master branch....I have built my docs using
godoc -http:=6060and mymasterbranch doesn't reflect what is present here - https://golang.org/pkg/net/httpAm i missing something, can you please point me to the right direction ?
bradfitz commentedon Oct 18, 2018
@mbj36, I don't know what you've done or what your environment is so it's hard to help. I suspect the godoc you're running is using the wrong GOROOT. You can explicitly set the GOROOT environment variable to point to your master checkout path.
Also perhaps of help: https://golang.org/doc/contribute.html and the #gocontributing channel on the Gophers Slack.
mbj36 commentedon Oct 19, 2018
@bradfitz Thanks for the reply.
This issue has been already fix here - https://tip.golang.org/pkg/net/http/#SameSite
agnivade commentedon Oct 19, 2018
If you want, you can still fix it by removing the
sfromprovides.The main goal is to mitigate the risk of cross-origin information leakage, and provide
ssome protection against cross-site request forgery attacks.gopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gogopherbot commentedon Oct 22, 2018
Change https://golang.org/cl/143480 mentions this issue:
doc: fix typo in cookie.gombj36 commentedon Oct 22, 2018
@agnivade Fixed
net/http: fix typo in the SameSite docs