Repository navigation
cmd/vet: reenable disabled cgo test #28829
Description
$ GOARCH=386 go test cmd/vet
--- FAIL: TestVet (0.58s)
--- FAIL: TestVet/cgo (0.06s)
vet_test.go:152: error check failed:
cgo.go:16: missing error "embedded pointer"
cgo.go:17: missing error "embedded pointer"
Unmatched Errors:
can't load package: package cgo: build constraints exclude all Go files in /usr/local/google/home/adonovan/goroot/src/cmd/vet/testdata/src/cgo
FAIL
FAIL cmd/vet 1.175s
The cgo test should be skipped in platforms that don't use cgo (otherwise build tags cause the package to be empty). But there's some confusion about whether 386 is a cgo platform. 'go list' says no, but build.Default.CgoEnabled says yes.
Investigate, fix and reenable the test.
Activity
gopherbot commentedon Nov 16, 2018
Change https://golang.org/cl/149937 mentions this issue:
cmd/vet: fix two failing test casescmd/vet: fix two failing test cases
gopherbot commentedon Nov 16, 2018
Change https://golang.org/cl/149958 mentions this issue:
cmd/vet: reenable cgo testcmd/vet: fix two failing test cases
cmd/vet: reenable cgo test