cmd/go: add a way to support GOFLAGS=-ldflags='-w -s' #29096
Labels
Milestone
Comments
mvdan
added
the
NeedsFix
|
Change https://golang.org/cl/152479 mentions this issue: |
|
#26849 is one possible mechanism. |
gopherbot
pushed a commit
that referenced
this issue
Dec 4, 2018
This partially reverts https://golang.org/cl/135035. Reason for revert: multiple -ldflags=-foo flags simply override each other, since that's the logic for per-package flags. The suggested 'GOFLAGS=-ldflags=-s -ldflags=-w' has never worked for 'go build', and even breaks 'go test' and 'go vet'. There should be a way to specify -ldflags='-w -s' via GOFLAGS, which is being tracked in #29096. For now, just remove the incorrect suggestion. Fixes #29053. Change-Id: I9203056f7e5191e894bcd16595a92df2fb704ea7 Reviewed-on: https://go-review.googlesource.com/c/152479 Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Alan Donovan <[email protected]> Run-TryBot: Daniel Martí <[email protected]>
|
Go 1.11 supposedly shipped with this feature, so I'm milestoning this for 1.13 to "get that back". Within quotes because it never actually worked :) |
|
The underlying use-case is the same as #26849. Consolidating into that issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The previous documentation example mentioned
GOFLAGS='-ldflags=-w -ldflags=-s', which does something completely different. The second per-package flag overrides the first, so the linker ends up being called with just-sand not-w -s.There should be a way to do
go build -ldflags='-w -s'viaGOFLAGS. This can either be done by tweakingGOFLAGS, or by tweaking per-package flags - I personally don't mind, as long as there's a way to achieve it./cc @bcmills @rsc
The text was updated successfully, but these errors were encountered: