Skip to content

cmd/go: module loader looks for the wrong tags if the "go-import" prefix includes the major-version suffix [1.12 backport] #30665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 7, 2019 · 2 comments
Closed

cmd/go: module loader looks for the wrong tags if the "go-import" prefix includes the major-version suffix [1.12 backport] #30665

gopherbot opened this issue Mar 7, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.1

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #30647 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to 1.12: this fixes a regression from GOPATH mode and the patch is small.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 7, 2019
@gopherbot gopherbot mentioned this issue Mar 7, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.1 milestone Mar 7, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/166317 mentions this issue: [release-branch.go1.12] cmd/go/internal/modfetch: handle codeRoot == path for paths with major-version suffixes

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Mar 8, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 8, 2019
@gopherbot
Copy link
Contributor Author

Closed by merging 4dd46a6 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Mar 8, 2019
[release-branch.go1.12] cmd/go/internal/modfetch: handle codeRoot == …
4dd46a6 
…path for paths with major-version suffixes

Fixes #30665

Change-Id: Icbcfdb3907bc003ac17a8c7df17ecb41daf82eb4
Reviewed-on: https://go-review.googlesource.com/c/go/+/166117
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
(cherry picked from commit 1ab9f68)
Reviewed-on: https://go-review.googlesource.com/c/go/+/166317
@golang golang locked and limited conversation to collaborators Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot