-
Notifications
You must be signed in to change notification settings - Fork 18k
proxy.golang.org: missing package #32542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report. CC @dmitshur. It looks like the module proxy referenced by https://dmitri.shuralyov.com/service/change?go-get=1, https://dmitri.shuralyov.com/api/module, doesn't support looking up versions by hash -- https://dmitri.shuralyov.com/api/module/dmitri.shuralyov.com/service/change/@v/a85b471d5412.info returns 404. Sorry for the trouble. It'll probably take a bit to figure out what to do about this but we'll get it fixed as soon as we can. |
This is true. My understanding is that it's a valid thing for a server speaking the module proxy protocol to do, is that right? I based that on https://golang.org/cmd/go/#hdr-Module_proxy_protocol:
A site serving from a fixed file system cannot be expected to respond to arbitrary lookups of versions by hash (since hashes can be specified with various lengths, the full 40 characters or shorter). |
Add support for 12-character lower-case git hash module queries. This is a temporary workaround for golang.org/issue/32542; my intention is to take it out when the upstream issue is resolved. /cc @heschik Updates golang/go#32542
I've temporarily modified the module server on my website to respond to a limited subset of module queries, in commit shurcooL/home@c1141c0. That change makes the current proxy.golang.org work as expected on dmitri.shuralyov.com/... modules, so this issue (and #32551) should not be occurring anymore (e.g., https://proxy.golang.org/dmitri.shuralyov.com/service/change/@v/v0.0.0-20181023043359-a85b471d5412.info now returns 200 OK). Once proxy.golang.org is updated to fully resolve this issue, I plan to remove that workaround. Hopefully this helps reduce any disruption in the meantime. For anyone interested in being able to reproduce this issue, I've created a new test module with a single pseudo-version. Its module path is https://dmitri.shuralyov.com/test/moduleproxy/dmitri.shuralyov.com/test/modtest3/@v/ - the static file system-based module server providing the modtest3 module https://proxy.golang.org/dmitri.shuralyov.com/test/modtest3/@v/v0.0.0-20181023043359-a85b471d5412.info - returns 410 Gone "not found: " right now, but it should be 200 OK once this issue is fully resolved |
The fix is rolled out to |
Thanks! I plan to remove the temporary workaround from my site tonight, and will test that it continues to work afterwards. Edit: This is done now. I'm not seeing any problems. Please let me know if you do spot a problem. |
Thanks for the quick response guys! |
What version of Go are you using (
go version
)?go version go1.12.5 linux/amd64
Does this issue reproduce with the latest release?
I have not checked yet.
What operating system and processor architecture are you using (
go env
)?What did you do?
go clean --modcache
go build
What did you expect to see?
Clean build with no errors
What did you see instead?
The build works without setting the GOPROXY to https://proxy.golang.org
The text was updated successfully, but these errors were encountered: