cmd/link: ELF linker won't set .dynsym info when there is no global symbols #34000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

cuonglm opened this issue Sep 1, 2019 · 1 comment

Labels

Member

cuonglm commented Sep 1, 2019 •

edited

Loading

This is follow up issue for #33358

Linker won't set .synsym info field when there's no global symbols, it must set it regardless.

Contributor

gopherbot commented Sep 1, 2019

Change https://golang.org/cl/192600 mentions this issue: cmd/link: always set .dynsym info field

gopherbot closed this as completed in

fa7d40a

t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue


          cmd/link: always set .dynsym info field

c327491

CL 187979 added set .dynsym info field, but it won't when
there are no global symbols. This CL sets that field
unconditionally.

Fixes golang#34000

Change-Id: Icc2f8bc74afdade88a377793e6760912b03686ba
Reviewed-on: https://go-review.googlesource.com/c/go/+/192600
Run-TryBot: Cuong Manh Le <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

golang locked and limited conversation to collaborators

gopherbot added the FrozenDueToAge label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.