-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: "fatal error: concurrent map writes" during go get #35317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/cc @bcmills @jayconrod |
Yep, there is definitely a race there. Thanks for the report. |
@gopherbot, please backport to 1.13: this is a regression and a data race. |
Backport issue(s) opened: #35318 (for 1.13). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
Change https://golang.org/cl/205067 mentions this issue: |
Change https://golang.org/cl/205517 mentions this issue: |
… modOnly map in runGet Updates #35317 Fixes #35318 Change-Id: Id858a25dc16a1bbff1802d25bcd4aca31c1133bc Reviewed-on: https://go-review.googlesource.com/c/go/+/205067 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Jay Conrod <[email protected]> (cherry picked from commit 7e71c9c) Reviewed-on: https://go-review.googlesource.com/c/go/+/205517
Change https://golang.org/cl/209237 mentions this issue: |
Adds an additional lock around an access to modOnly. Updates #35317 Change-Id: Ia1e75f9a674ec2a2c0489b41283c1cd3e7924d1e Reviewed-on: https://go-review.googlesource.com/c/go/+/209237 Run-TryBot: Jay Conrod <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Jay Conrod <[email protected]>
Change https://golang.org/cl/209222 mentions this issue: |
… modOnly map in runGet Adds an additional lock around an access to modOnly. Updates #35317 Fixes #35318 Change-Id: Ia1e75f9a674ec2a2c0489b41283c1cd3e7924d1e Reviewed-on: https://go-review.googlesource.com/c/go/+/209237 Run-TryBot: Jay Conrod <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Jay Conrod <[email protected]> (cherry picked from commit 9174e2c) Reviewed-on: https://go-review.googlesource.com/c/go/+/209222 Run-TryBot: Alexander Rakoczy <[email protected]>
Facing a similar issue while running Telegraf. Telegraf version: 1.13.4 Error: goroutine 3184 [running]: |
@sakshi-bansal, this issue is about a concurrent write within the The general solution to these sorts of issues is to build the program using the race detector and then run it and fix the reported races. |
go version go1.14 darwin/amd64 also found this error, only run sync.Map Store() func |
@phpstudyer please open a new issue. Thank you. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
1.13.4, yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Was using
go get
to update some dependencies, normally. It was essentiallygo get -d -t <a bunch of stuff with @upgrade>
.What did you expect to see?
No panics.
What did you see instead?
From
go get
:Forgive me, I don't yet have a reliable repro; I just saw this panic when going about my day after the most recent point release.
The text was updated successfully, but these errors were encountered: