Skip to content

net/http: HTTP/2 with MaxConnsPerHost hangs or crashes [1.13 backport] #36583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jan 15, 2020 · 3 comments
Closed

net/http: HTTP/2 with MaxConnsPerHost hangs or crashes [1.13 backport] #36583

gopherbot opened this issue Jan 15, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.8

Comments

@gopherbot
Copy link
Contributor

@networkimprov requested issue #34941 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport to 1.13

This is a regression, as documented in the issue comments.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 15, 2020
@gopherbot gopherbot mentioned this issue Jan 15, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.7 milestone Jan 15, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/215177 mentions this issue: [release-branch.go1.13] net/http: only decrement connection count if we removed a connection

@dmitshur dmitshur modified the milestones: Go1.13.7, Go1.13.8 Jan 27, 2020
@toothrot toothrot added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 11, 2020
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround that only impacts 1.13 and tip.

@gopherbot
Copy link
Contributor Author

Closed by merging 224a180 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Feb 11, 2020
@fraenkel @toothrot
[release-branch.go1.13] net/http: only decrement connection count if …
224a180 
…we removed a connection

The connection count must only be decremented if the persistent
connection was also removed.

Fixes #36583

Change-Id: I5070717d5d9effec78016005fa4910593500c8cf
Reviewed-on: https://go-review.googlesource.com/c/go/+/202087
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/215177
Run-TryBot: Alexander Rakoczy <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.8
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot