Skip to content

test: make run.go handle ALL tests #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Sep 23, 2012 · 20 comments
Closed

test: make run.go handle ALL tests #4139

rsc opened this issue Sep 23, 2012 · 20 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.5

Comments

@rsc
Copy link
Contributor

rsc commented Sep 23, 2012 

I have been adding to tests in the test directory without realizing that run.go is not
running them, because they have command lines it cannot handle. Before Go 1 we MUST make
run.go handle all the tests that the run script does, or else whitelist the ones we
intend not to handle and also mark that fact at the top of each ignored test file.
@rsc
Copy link
Contributor Author

rsc commented Sep 23, 2012

Comment 1:

I am going to do the whitelist now but will leave this bug open until we've made it run
all the tests.

@rsc
Copy link
Contributor Author

rsc commented Dec 10, 2012

Comment 2:

Labels changed: added size-l.

@remyoudompheng
Copy link
Contributor

Comment 3:

Remaining:
* linkx.go : wants -X flag for linker
* sinit.go : greps something in compiled binary
* fixedbugs/bug248.go: wants to mix errorcheckdir and rundir in a single directory
* fixedbugs/bug302.go: wants to test both .$O and .a imports.
* fixedbugs/bug345.go: currently broken, need to remove -D or -I flag from compiler
* fixedbugs/bug369.go: performance test of loop, should it still be there?
* fixedbugs/bug429.go: runs a program and expects it to fail
* bugs/bug395.go: ok to skip, test for issue #1909.

@rsc
Copy link
Contributor Author

rsc commented Mar 12, 2013

Comment 4:

Labels changed: added go1.1maybe, removed go1.1.

@robpike
Copy link
Contributor

robpike commented May 18, 2013

Comment 5:

Labels changed: added go1.2maybe, removed go1.1maybe.

@rsc
Copy link
Contributor Author

rsc commented Jul 30, 2013

Comment 6:

We are so close. Let's finish this off.

@ianlancetaylor
Copy link
Contributor

Comment 7:

Removing Go1.2Maybe tag; this is very desirable but is not a release issue.

Labels changed: removed size-l, go1.2maybe.

@rsc
Copy link
Contributor Author

rsc commented Nov 27, 2013

Comment 8:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 9:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 10:

Labels changed: added repo-main.

@ianlancetaylor
Copy link
Contributor

Comment 11:

Labels changed: added suggested, removed priority-later.

@josharian
Copy link
Contributor

Comment 12:

sinit.go has been broken for 8 months (issue #8746). Maybe it's time to do this.

@josharian
Copy link
Contributor

Comment 13:

Bumping this to Release-Go1.4 on the grounds that multiple tests from ./run are failing,
including recent uncaught real regressions (issue #8806).
I'll start migrating the tests that are currently failing and aim for minimal impact on
run.go.

Labels changed: added release-go1.4, removed release-none.

@gopherbot
Copy link
Contributor

Comment 14:

CL https://golang.org/cl/142680043 mentions this issue.

@gopherbot
Copy link
Contributor

Comment 15:

CL https://golang.org/cl/144630044 mentions this issue.

@gopherbot
Copy link
Contributor

Comment 16:

CL https://golang.org/cl/145420043 mentions this issue.

@gopherbot
Copy link
Contributor

Comment 17:

CL https://golang.org/cl/147220043 mentions this issue.

@josharian
Copy link
Contributor

Comment 18:

This issue was updated by revision 9b54444.

Update issue #8746
Update issue #8806
LGTM=rsc
R=rsc, bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/144630044
Committer: Russ Cox

@gopherbot
Copy link
Contributor

Comment 19:

CL https://golang.org/cl/168490043 mentions this issue.

@ianlancetaylor
Copy link
Contributor

Comment 20:

No point in pushing on this further at this point in the release cycle.  We can finish
this after the 1.4 release.

Labels changed: added release-go1.5, removed release-go1.4.

@rsc rsc added accepted Suggested Issues that may be good for new contributors looking for work to do. labels Nov 12, 2014
@rsc rsc self-assigned this Nov 12, 2014
rsc pushed a commit that referenced this issue Dec 9, 2014
@ianlancetaylor
test: write Go wrapper code so that bug302 can be run by run.go
c5de72b 
Issue #4139.

Change-Id: I50d85a65b22c0cfb4d2a078cee45cf7adb23ba77
Reviewed-on: https://go-review.googlesource.com/1210
Reviewed-by: Russ Cox <[email protected]>
Reviewed-by: Josh Bleecher Snyder <[email protected]>
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
josharian added a commit to josharian/go that referenced this issue Dec 18, 2014
@josharian
test: migrate remaining tests to run.go
f9c9fae 
* bug248 was split into a rundir half (bug248) and an errorcheckdir half (bug248b).
* bug345, bug369, and bug429 were ported from bash commands to run scripts. bug369 remains disabled.
* bug395 is a test for issue 1909, which is still open. It is marked as skip now and will be usable with compile with run.go when issue 1909 is fixed.

Fixes golang#4139

Updates golang#1909

Change-Id: Ibb5fbfb5cf72ddc285829245318eeacd3fb5a636
josharian added a commit to josharian/go that referenced this issue Dec 22, 2014
@josharian
test: migrate remaining tests to run.go
866f56d 
* bug248, bug345, bug369, and bug429 were ported from bash commands to run scripts. bug369 remains disabled.
* bug395 is a test for issue 1909, which is still open. It is marked as skip now and will be usable with compile with run.go when issue 1909 is fixed.

Fixes golang#4139

Updates golang#1909

Change-Id: Ibb5fbfb5cf72ddc285829245318eeacd3fb5a636
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
7 participants
@bradfitz @josharian @rsc @remyoudompheng @ianlancetaylor @robpike @gopherbot