Skip to content

x/build/cmd/coordinator: dimmed out "ok" results should have a tooltip too #42405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Nov 5, 2020 · 2 comments
Closed

x/build/cmd/coordinator: dimmed out "ok" results should have a tooltip too #42405

dmitshur opened this issue Nov 5, 2020 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Member

dmitshur commented Nov 5, 2020

Results from builders with a known issue are dimmed out on build.golang.org (this was #38283).

There's no tooltip that explains why a build result is dimmed out when a build is passing, only when it was a failure. This can make it hard to discover why some "ok" boxes are dimmed out.

Filing this so we don't forget to fix it, but it might happen as part of work for #34744.

CC @golang/release, @aclements.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 5, 2020
@dmitshur dmitshur added this to the Unreleased milestone Nov 5, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 5, 2020
@dmitshur dmitshur self-assigned this Dec 8, 2021
@dmitshur dmitshur changed the title x/build/{cmd/coordinator,app/appengine}: dimmed out "ok" results should have a tooltip too x/build/cmd/coordinator: dimmed out "ok" results should have a tooltip too Dec 8, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/370334 mentions this issue: cmd/coordinator: consistently dim columns for builders with known issue

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/370335 mentions this issue: cmd/coordinator: add link to known issue on builders page

gopherbot pushed a commit to golang/build that referenced this issue Dec 9, 2021
@dmitshur
cmd/coordinator: add link to known issue on builders page
f1ed2d1 
The tooltip for builders with a known issue is displayed consistently
as of the last commit, but accessing a link in a tooltip is not easy.
It's reasonable to expect that known issues would be linked on the
builders page. Add a column with links there to make it so.

For golang/go#42405.

Change-Id: I5e915132f2ca05efc69bc76da1f25b897569be5d
Reviewed-on: https://go-review.googlesource.com/c/build/+/370335
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot