x/review/git-codereview: test timed out on windows-arm-zx2c4 builder

[bcmills]

2020-09-11T20:38:40-0edcede/windows-arm-zx2c4

Not obvious to me whether the builder is just slow or the test triggered some kind of deadlock.

CC @zx2c4 @golang/release

[zx2c4]

It might just be slow. If this test is doing a lot of disk IO, that can really slow things down.

[bcmills]

It's testing the git-codereview Git hooks, so it probably does a moderate amount of I/O, but it's not exactly a long, intensive test — 10 minutes seems like it should be more than adequate.

That said, I can't seem to run the test locally to get a baseline for how long it should take (#42926).

[zx2c4]

If it's doing a lot of git operations, this hits a triple whammy of slow: NTFS small file performance is pretty bad, the I/O on this box is pretty slow, and git itself is compiled only for x86 not arm, so it runs in Windows' rosetta2 situation.

[bcmills]

In that case, would it make sense to configure the builder to skip the x/review repo, or perhaps to use a larger timeout scale factor?

[zx2c4]

I think that's at least worth a try, yes. For starters, the timeout scale factor. I'm not quite sure how to go about doing that in the x/build repo, if you want to take a stab at it. Alternatively, if there's some env var I should set on the builder, I can do that.

[dmitshur]

The GO_TEST_TIMEOUT_SCALE variable can be used to scale timeout, but it applies to the entire builder, not a specific repository. It's defined here, and there are many examples of it used in dashboard/builders.go.

[zx2c4]

Will send a CL.

[gopherbot]

Change https://golang.org/cl/274572 mentions this issue: dashboard: expand time scale for windows-arm builder

[gopherbot]

Change https://golang.org/cl/275237 mentions this issue: cmd/relui: add datastore support

[bcmills]

This builder no longer exists, so the issue is obsolete.
(We may need to revisit this when a new windows-arm builder is added; see #47019.)