Skip to content

reflect: resolve struct tag syntax question #43226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Dec 16, 2020 · 4 comments
Closed

reflect: resolve struct tag syntax question #43226

rsc opened this issue Dec 16, 2020 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.16

Comments

@rsc
Copy link
Contributor

rsc commented Dec 16, 2020

Proposal #40281 needs to be resolved for the release.
@rsc rsc added this to the Go1.16 milestone Dec 16, 2020
@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Dec 16, 2020
@toothrot toothrot removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 17, 2020
@toothrot
Copy link
Contributor

toothrot commented Jan 7, 2021

This issue has been resolved. See #40281.

@toothrot toothrot closed this as completed Jan 7, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/281515 mentions this issue: Revert "reflect: support multiple keys in struct tags"

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/281973 mentions this issue: Revert "go/analysis/passes/structtag: recognize multiple keys per tag"

gopherbot pushed a commit to golang/tools that referenced this issue Jan 7, 2021
@ianlancetaylor
Revert "go/analysis/passes/structtag: recognize multiple keys per tag"
4ed967d 
This reverts CL 277092.

Proposal golang/go#40281 was initially accepted, then declined.  Stop accepting
the new, now once again invalid, format.

For golang/go#40281
For golang/go#43083
For golang/go#43226

Change-Id: Ida97263048f3a048f904a844f577d8353e3a1afa
Reviewed-on: https://go-review.googlesource.com/c/tools/+/281973
Trust: Ian Lance Taylor <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/282412 mentions this issue: cmd: update to latest golang.org/x/tools

gopherbot pushed a commit that referenced this issue Jan 7, 2021
@ianlancetaylor
Revert "reflect: support multiple keys in struct tags"
9ec21a8 
Proposal #40281 was initially accepted, but has now been declined.
This CL removes most of the work done to implement it.

Specifically this reverts CLs 248341, 274448, 274474, and 278392.

For #40281
For #43226

Change-Id: I5a9ebb4d9cb5fb0962434b64c59beb8343030be5
Reviewed-on: https://go-review.googlesource.com/c/go/+/281515
Trust: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
gopherbot pushed a commit that referenced this issue Jan 8, 2021
@ianlancetaylor
cmd: update to latest golang.org/x/tools
54bd1cc 
In particular bring in CL 201973, which reverts support for multiple
keys in a struct tag.

For #40281
For #43083
For #43226

Change-Id: I66e76639cbbca55bdbff6956acdb0a97650fdd31
Reviewed-on: https://go-review.googlesource.com/c/go/+/282412
Trust: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
gopherbot pushed a commit to golang/tools that referenced this issue Jan 11, 2021
@ianlancetaylor @dmitshur
Revert "go/analysis/passes/structtag: recognize multiple keys per tag"
21398c4 
This reverts CL 277092.

Proposal golang/go#40281 was initially accepted, then declined.  Stop accepting
the new, now once again invalid, format.

For golang/go#40281
For golang/go#43083
For golang/go#43226

Change-Id: Ida97263048f3a048f904a844f577d8353e3a1afa
Reviewed-on: https://go-review.googlesource.com/c/tools/+/281973
Trust: Ian Lance Taylor <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
@golang golang locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
5 participants
@toothrot @rsc @ianlancetaylor @gopherbot and others