x/tools/gopls: suggests invalid package names

[seankhliao]

go: tip
gopls: v0.6.6

With module / directory names with - in them, gopls uses that directly as a suggested package name, which is invalid

[ShoshinNikita]

We can replace - with _. But there are other cases:

• directory name starts with a digit
• directory name contains one of these characters: -, . or ~
• directory name contains invalid characters (whitespace, comma, etc.)

I think we can ignore the last case and don't show suggestions at all because it's not possible to import such packages (https://golang.org/ref/mod#go-mod-file-ident). But what is the expected behavior in other situations?

[mattheusv]

What do you think about ignoring anything that is not a letter? So in case of foo-bar, 123foobar, foo bar will be always suggest foobar

[ShoshinNikita]

@msAlcantara Thanks for the idea! I was planning to convert all punctuation to _, but it would conflict with the package name convention. So, ignoring the punctuation is a better strategy.

[gopherbot]

Change https://golang.org/cl/313092 mentions this issue: internal/lsp/source/completion: suggest only valid package names