Skip to content

archive/zip: duplicate entries in FS interface [1.16 backport] #45347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 1, 2021 · 3 comments
Closed

archive/zip: duplicate entries in FS interface [1.16 backport] #45347

gopherbot opened this issue Apr 1, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.4

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #45345 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport to 1.16.

This appears to be a bug in the FS interface supported by archive/zip. This interface is new in the 1.16 release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 1, 2021
@gopherbot gopherbot mentioned this issue Apr 1, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.4 milestone Apr 1, 2021
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Apr 22, 2021
@toothrot
Copy link
Contributor

Approved. This only impacts 1.16. The new API is just broken for zip files without this change.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 22, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/315249 mentions this issue: [release-branch.go1.16] archive/zip: only return directory once via io/fs.FS

@gopherbot
Copy link
Contributor Author

Closed by merging e67a58b to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Apr 30, 2021
@ianlancetaylor
[release-branch.go1.16] archive/zip: only return directory once via i…
e67a58b 
…o/fs.FS

While we're here fix the ModTime value for directories.

For #43872
For #45345
Fixes #45347

Change-Id: I155e6517713ef6a9482b9431f1167a44337c6ad2
Reviewed-on: https://go-review.googlesource.com/c/go/+/311530
Trust: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Jeremy Faller <[email protected]>
(cherry picked from commit 87e4dcd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/315249
Trust: Jeremy Faller <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.4
Development

No branches or pull requests
2 participants
@toothrot @gopherbot