Skip to content

x/tools/gopls/internal/regtest: TestDeleteModule_Interdependent flakes due to orphaned file reloading #46375

Description

@findleyr

Looking at regtest failures for issue #46183, one common source of flakes in slower builders is TestDeleteModule_Interdependent in golang.org/x/tools/gopls/internal/regtest/workspace.

For example:
https://build.golang.org/log/c962f4fbb5df4c74ebe76f8aeb610eed3065f267
https://storage.googleapis.com/go-build-log/8b462d75/freebsd-amd64-12_2_e126050b.log

This test failure appears to be a race related to orphaned file reloading. All failures have a log message about reloadOrphanedFiles, but when it succeeds locally I never see this log message.

Since it is an experimental feature, we should disable this test until we understand it.

CC @stamblerre @heschi

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeTestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions