Skip to content

x/vulndb/client: frequent failures in TestClient #46419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue May 27, 2021 · 5 comments
Closed

x/vulndb/client: frequent failures in TestClient #46419

bcmills opened this issue May 27, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented May 27, 2021

There appear to be three different failure modes, perhaps all related to the same underlying problem:

--- FAIL: TestClient (0.01s)
    client_test.go:134: Get "http://localhost:8080/index.json": dial tcp 127.0.0.1:8080: connect: connection refused

2021-05-21T02:20:14-c856ba8/android-386-emu
2021-05-21T02:20:14-c856ba8/dragonfly-amd64
2021-05-21T02:20:14-c856ba8/linux-386
2021-05-21T02:20:14-c856ba8/linux-386-sid
2021-05-21T02:20:14-c856ba8/linux-amd64
2021-05-21T02:20:14-c856ba8/linux-amd64-jessie
2021-05-21T02:20:14-c856ba8/linux-amd64-wsl
2021-05-21T02:20:14-c856ba8/linux-arm-aws
2021-05-21T02:20:14-c856ba8/linux-arm64-aws
2021-05-21T02:20:14-c856ba8/linux-ppc64-buildlet
2021-05-21T02:20:14-c856ba8/linux-ppc64le-buildlet
2021-05-21T02:20:14-c856ba8/linux-ppc64le-power9osu
2021-05-21T02:20:14-c856ba8/openbsd-amd64-64
2021-04-20T18:00:48-e0c00fa/dragonfly-amd64
2021-04-20T18:00:48-e0c00fa/linux-arm-aws
2021-04-20T18:00:48-e0c00fa/linux-ppc64le-buildlet
2021-04-20T18:00:48-e0c00fa/linux-ppc64le-power9osu

--- FAIL: TestClient (0.05s)
    client_test.go:129: parse "file://C:\\Users\\gopher\\AppData\\Local\\Temp\\TestClient353858962\\001": invalid port ":\\Users\\gopher\\AppData\\Local\\Temp\\TestClient353858962\\001" after host

2021-05-21T02:20:14-c856ba8/windows-386-2008
2021-05-21T02:20:14-c856ba8/windows-amd64-2016
2021-05-21T02:20:14-c856ba8/windows-amd64-longtest
2021-05-21T02:20:14-c856ba8/windows-amd64-race
2021-05-21T02:20:14-c856ba8/windows-arm64-aws
2021-04-20T18:00:48-e0c00fa/windows-386-2008
2021-04-20T18:00:48-e0c00fa/windows-amd64-2016
2021-04-20T18:00:48-e0c00fa/windows-amd64-longtest
2021-04-20T18:00:48-e0c00fa/windows-amd64-race

--- FAIL: TestClient (0.02s)
    client_test.go:134: Get "http://localhost:8080/index.json": dial tcp: Protocol not available

2021-05-21T02:20:14-c856ba8/js-wasm
2021-04-20T18:00:48-e0c00fa/js-wasm

CC @FiloSottile @rolandshoemaker
@gopherbot gopherbot added this to the Unreleased milestone May 27, 2021
@bcmills bcmills mentioned this issue May 27, 2021
Closed
@bcmills
Copy link
Contributor Author

bcmills commented May 27, 2021

(Release blocker for Go 1.17 via #11811.)

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 27, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.17 May 27, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jun 1, 2021

Looks like CL 323132 fixed this everywhere except js-wasm.

@rolandshoemaker
Copy link
Member

Oh bah, I missed the js-wasm section of the initial issue, will send a fix in a moment.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/324089 mentions this issue: client: skip test on js

gopherbot pushed a commit to golang/vulndb that referenced this issue Jun 2, 2021
@rolandshoemaker
client: skip test on js
68c54ab 
Since it doesn't support doing things with sockets.

Updates golang/go#46419.

Change-Id: I22c86706d5ab9ffc6b62ca850aab6621eddedea7
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/324089
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
@heschi heschi removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Jun 10, 2021
@rolandshoemaker
Copy link
Member

I believe this has been fixed.

@heschi heschi closed this as completed Jun 10, 2021
@golang golang locked and limited conversation to collaborators Jun 10, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
Go1.17
Development

No branches or pull requests
5 participants
@rolandshoemaker @bcmills @julieqiu @gopherbot @heschi