Skip to content

go/types: bug in new package qualification logic+misleading tests #46905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Jun 24, 2021 · 3 comments
Closed

go/types: bug in new package qualification logic+misleading tests #46905

findleyr opened this issue Jun 24, 2021 · 3 comments
Labels
FrozenDueToAge release-blocker
Milestone
Go1.17

Comments

@findleyr
Copy link
Member

As @bcmills points out in CL 330253, there is a bug in the package qualification logic of CL 313035. The nominal bug is the use of pkg rather than check.pkg on line 34 of errors.go, but I additionally noticed that our test coverage is not functioning as we expect: testdata error message extraction stops at the first ", so assertions in check tests that were checking that imports were qualified were not actually checking anything.

Opening this as a release blocker for tracking purposes. I'm fixing now.
@findleyr findleyr added this to the Go1.17 milestone Jun 24, 2021
@findleyr findleyr self-assigned this Jun 24, 2021
@findleyr
Copy link
Member Author

FYI @golang/release @griesemer

This should be fixed today (I'm on it).

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/330629 mentions this issue: go/types: fix bug in package qualification logic

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/336350 mentions this issue: [dev.typeparams] cmd/compile/internal/types2: fix a bug in package qualification logic

gopherbot pushed a commit that referenced this issue Jul 26, 2021
@griesemer
[dev.typeparams] cmd/compile/internal/types2: fix a bug in package qu…
b93f646 
…alification logic

This is a partial port of https://golang.org/cl/330629, containing
only the actual bug fix and adjustements to another test file.

The respective test case has not been ported yet as it requires
some bigger adjustments.

For #46905

Change-Id: Ibd20658b8a31855da20cf56e24bcce9560656ca0
Reviewed-on: https://go-review.googlesource.com/c/go/+/336350
Trust: Robert Griesemer <[email protected]>
Run-TryBot: Robert Griesemer <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
2 participants
@gopherbot @findleyr