Skip to content

net: LookupMX behaviour broken [1.16 backport] #46999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 30, 2021 · 5 comments
Closed

net: LookupMX behaviour broken [1.16 backport] #46999

gopherbot opened this issue Jun 30, 2021 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.16.6

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jun 30, 2021 •
edited by FiloSottile
Loading

@FiloSottile requested issue #46979 to be considered for backport to the next 1.16 minor release.

@gopherbot please open a backport issue for Go 1.16, this is a regression in the last minor release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 30, 2021
@gopherbot gopherbot mentioned this issue Jun 30, 2021
Closed
@FiloSottile FiloSottile changed the title net: LookupMX behaviour broken [1.17 backport] net: LookupMX behaviour broken [1.16 backport] Jun 30, 2021
@gopherbot gopherbot added this to the Go1.16.6 milestone Jun 30, 2021
@FiloSottile
Copy link
Contributor

I meant Go 1.16, not Go 1.17, clearly 🤦 nice that gopherbot still milestoned it correctly once I fixed the title.

@dmitshur dmitshur mentioned this issue Jul 1, 2021
Closed
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/332371 mentions this issue: [release-branch.go1.16] net: don't reject null mx records

@dmitshur
Copy link
Member

dmitshur commented Jul 1, 2021

We've considered this in a release meeting. Approving as it is a serious issue without a workaround. This backport applies to both 1.16 (this issue) and 1.15 (#47012).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jul 1, 2021
@gopherbot
Copy link
Contributor Author

Closed by merging a91ed83 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Jul 8, 2021
@rolandshoemaker
[release-branch.go1.16] net: don't reject null mx records
a91ed83 
Bypass hostname validity checking when a null mx record is returned as,
defined in RFC 7505.

Updates #46979
Updates #46999

Change-Id: Ibe683bd6b47333a8ff30909fb2680ec8e10696ef
Reviewed-on: https://go-review.googlesource.com/c/go/+/332094
Trust: Roland Shoemaker <[email protected]>
Trust: Katie Hockman <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Katie Hockman <[email protected]>
(cherry picked from commit 03761ed)
Reviewed-on: https://go-review.googlesource.com/c/go/+/332371
Run-TryBot: Katie Hockman <[email protected]>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/333330 mentions this issue: [release-branch.go1.16] net: filter bad names from Lookup functions instead of hard failing

gopherbot pushed a commit that referenced this issue Jul 8, 2021
@rolandshoemaker
[release-branch.go1.16] net: filter bad names from Lookup functions i…
fb052db 
…nstead of hard failing

Instead of hard failing on a single bad record, filter the bad records
and return anything valid. This only applies to the methods which can
return multiple records, LookupMX, LookupNS, LookupSRV, and LookupAddr.

When bad results are filtered out, also return an error, indicating
that this filtering has happened.

Updates #46241
Updates #46979
Fixes #46999

Change-Id: I6493e0002beaf89f5a9795333a93605abd30d171
Reviewed-on: https://go-review.googlesource.com/c/go/+/332549
Trust: Roland Shoemaker <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
(cherry picked from commit 296ddf2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/333330
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@golang golang locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.16.6
Development

No branches or pull requests
3 participants
@FiloSottile @dmitshur @gopherbot