-
Notifications
You must be signed in to change notification settings - Fork 18k
x/build/cmd/relui: create production and staging environments #47407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Change https://golang.org/cl/369254 mentions this issue: |
Add cloud build configuration for running integration tests for relui. For golang/go#47407 Change-Id: Id06846f4ecd7129b112b5f130cb72b257cc6898a Reviewed-on: https://go-review.googlesource.com/c/build/+/369254 Trust: Alex Rakoczy <[email protected]> Run-TryBot: Alex Rakoczy <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Edit: I originally suggested a "dry-run" semi-environment, but by now think that needs to be a separate mode. It probably deserves its own issue as this issue is about setting up actual running environments, so I'll withdraw the comment for now. Original commentIn addition to production and staging, I suggest having a third semi-environment, "dry-run mode". It would be intended for local execution and wouldn't need to be deployed anywhere. It would be similar to how We can change the color scheme of the header for all 3 modes so they're easy to tell apart, e.g., something like: |
@toothrot Should the "Production" checkbox be checked now, given #47401 is resolved and we have https://build.golang.org/releases/? I'm about ready to send CLs that'll resolve #47402. That means running I don't know what we want the long-term solution for this to be, perhaps that needs more discussion. As an intermediate step here to enable progress, are you okay with reusing the existing (If it is a goal not to use |
I've had a chance to cover this with @heschi today, and I think we found agreement on something with good properties that might not take too much time to begin with. In that case, the intermediate step of reusing |
Change https://go.dev/cl/410235 mentions this issue: |
Updates golang/go#47407 Change-Id: I4a07a18e817ff5deac8de97779d2957396e053f7 Reviewed-on: https://go-review.googlesource.com/c/build/+/410235 Run-TryBot: Alex Rakoczy <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
Blocked by #47401
The text was updated successfully, but these errors were encountered: