Skip to content

[dev.fuzz] testing: fuzzminimizetime should accept 0x / 0s / maybe just "0" to disable minimization #48321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Sep 10, 2021 · 2 comments
Closed

[dev.fuzz] testing: fuzzminimizetime should accept 0x / 0s / maybe just "0" to disable minimization #48321

bcmills opened this issue Sep 10, 2021 · 2 comments
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done.

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 10, 2021 •
edited
Loading

In an attempt to work around #48320, I tried passing -fuzzminimizetime=0s. That was rejected with invalid duration.

@katiehockman suggested -fuzzminimizetime=0x, but that fails with invalid count.

Both of those should probably be valid.
@bcmills bcmills added fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. labels Sep 10, 2021
@katiehockman katiehockman self-assigned this Sep 10, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/349089 mentions this issue: [dev.fuzz] testing: allow -fuzzminimizetime to be 0

gopherbot pushed a commit that referenced this issue Sep 10, 2021
@katiehockman
[dev.fuzz] testing: allow -fuzzminimizetime to be 0
363f2f3 
Fixes #48321

Change-Id: I1547379eb7a703f7f3c4594d27833eb3587796a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/349089
Trust: Katie Hockman <[email protected]>
Run-TryBot: Katie Hockman <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
@bcmills bcmills mentioned this issue Sep 10, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/349090 mentions this issue: [dev.fuzz] internal/fuzz: fix bug for -fuzzminimizetime of zero

gopherbot pushed a commit that referenced this issue Sep 10, 2021
@katiehockman
[dev.fuzz] internal/fuzz: fix bug for -fuzzminimizetime of zero
17f62c0 
Updates #48321

Change-Id: Ib35388f17580f1244a6eae4e5879f8329b6b44ce
Reviewed-on: https://go-review.googlesource.com/c/go/+/349090
Trust: Katie Hockman <[email protected]>
Run-TryBot: Katie Hockman <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Security
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @katiehockman