Skip to content

cmd/go2go: shut down go2go playground #48517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianlancetaylor opened this issue Sep 21, 2021 · 15 comments
Closed

cmd/go2go: shut down go2go playground #48517

ianlancetaylor opened this issue Sep 21, 2021 · 15 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ianlancetaylor
Copy link
Contributor

The go2go playground served its purpose and is now out of date and is more confusing than helpful. It's time to shut it down.

Ideally go2goplay.golang.org should be replaced with a static page saying something along the lines of

This playground was used during the development of the generics proposal. It is now out of date and has been shut down. The generics proposal (https://golang.org/s/generics-proposal) has been accepted and (as of September 2021) is under active development aiming for inclusion in the Go 1.18 release.

CC @griesemer @golang/osp-team
@toothrot toothrot added this to the Unreleased milestone Sep 21, 2021
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 21, 2021
@beoran
Copy link

beoran commented Sep 21, 2021

While that is fair enough, it would be helpful to have a playground with a preview of Go 1.18 available, perhaps a recent development version. If it is not too much effort of course.

@seankhliao
Copy link
Member

@beoran see #33629

@ianlancetaylor ianlancetaylor mentioned this issue Sep 24, 2021
Open
@thanm thanm mentioned this issue Nov 2, 2021
Closed
@ianlancetaylor
Copy link
Contributor Author

We should perhaps have the go2go playground redirect to the tip playground. Though I don't know that we have a tip playground running at this point.

CC @golang/release

@changkun
Copy link
Member

changkun commented Nov 9, 2021

It would be nice to serve tip, and the latest two releases, as proposal accepted in #33629

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/362854 mentions this issue: deploy: add deployment configuration for a tipgo playground instance

@findleyr
Copy link
Member

@changkun I agree that would be nice, but that is a modestly sized project that unfortunately none of us have time for at the moment. It is also the case that the gotip playground will be redeployed many times a day, which may not be desirable for the non-tip playground (I'm honestly not sure if that argument holds water).

For now, I am planning to deploy gotipplay.golang.org, which will be identical to play.golang.org but using Go tip (I will probably also try to indicate this somewhere in the HTML, and change examples). For technical reasons the URL must be gotipplay.golang.org, not e.g. gotip.play.golang.org.

gopherbot pushed a commit to golang/playground that referenced this issue Nov 10, 2021
@findleyr
deploy: add deployment configuration for a gotip playground instance
f8a58a0 
For now, just define GCP configuration. In a subsequent CL we should
parameterize the playground UI to indicate that this is tip go.

Updates golang/go#48517

Change-Id: I8a885126b95f60e02f46f7557cada2ec2e0b2882
Reviewed-on: https://go-review.googlesource.com/c/playground/+/362854
Trust: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@findleyr
Copy link
Member

With help from @toothrot, https://gotipplay.golang.org is deployed. Next step is to clearly identify the go version in the UI, and redirect go2go.

The plan for the latter is to just overwrite the go2go app with a simple redirector.

@griesemer
Copy link
Contributor

And it works! Cool.

@ianlancetaylor
Copy link
Contributor Author

Thanks!

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/363980 mentions this issue: gotipplay: identify the gotip playground build in the UI

gopherbot pushed a commit to golang/playground that referenced this issue Nov 17, 2021
@findleyr
gotipplay: identify the gotip playground build in the UI
6987932 
Attempt to clearly label the Go tip playground as a development build,
and surface the version string.

For some reason I had to install git in the build-playground phase of
the Docker build, to avoid errors from the Go command. I'm not sure why
this is, but it seems harmless.

For golang/go#48517

Change-Id: I35b150686c9f177d76024cc38ff62cb8785525e0
Reviewed-on: https://go-review.googlesource.com/c/playground/+/363980
Trust: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/364374 mentions this issue: examples: derive examples from the examples directory

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/364858 mentions this issue: go2go: add an app engine service to redirect go2goplay to gotipplay

gopherbot pushed a commit to golang/playground that referenced this issue Nov 19, 2021
@findleyr
examples: derive examples from the examples directory
8bb1e2e 
With the gotip playground we may want to swap out examples with greater
frequency, to demonstrate new features at Go tip. Make this easier by
deriving examples directly from the examples directory via a new
examplesHandler type. This also enables having dynamic content for
hello.txt, which depends on the value of runtime.GoVersion().

This will impact the non-tip playground in a few ways:
- We will now pre-load examples at server start up.
- Examples will be sorted by their title (with the exception of Hello,
  playground, which is always first).
- We will set a CORS header for examples. This was added for consistency
  with other handlers, and seems harmless.

Generalize TestShare to TestServer, and use it to test the examples
handler.

Add a single gotip example demonstrating generics.

Updates golang/go#48517

Change-Id: I7ab58eb391829d581f7aeae95c291666be5718b9
Reviewed-on: https://go-review.googlesource.com/c/playground/+/364374
Trust: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
gopherbot pushed a commit to golang/playground that referenced this issue Nov 22, 2021
@findleyr
go2go: add an app engine service to redirect go2goplay to gotipplay
11560ec 
This service will overwrite the existing go2go playground.

Updates golang/go#48517

Change-Id: Idc9e6733cc213a2c3e84c71d1c4746dc31feeb62
Reviewed-on: https://go-review.googlesource.com/c/playground/+/364858
Trust: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/366634 mentions this issue: deploy: add daily schedule for gotip playground

@findleyr
Copy link
Member

@toothrot just deployed the redirect service for go2goplay.golang.org, so this is now done.

@ianlancetaylor
Copy link
Contributor Author

Thanks!

gopherbot pushed a commit to golang/playground that referenced this issue Nov 30, 2021
@toothrot
deploy: add daily schedule for gotip playground
f648226 
Create a scheduled trigger to deploy the gotip playground every
America/New_York morning. I attempted to create and manage the trigger
with gcloud alpha builds triggers create scheduled, however I had to create the
schedule portion manually in the web interface.

There's probably a way to manage it with configuration in the CLI, but I
added documentation to the Makefile on how to update it manually in the
meantime.

Create command:

gcloud alpha builds triggers create scheduled --project=golang-org \
  --schedule="15 11 * * *" \
  --time-zone="America/New_York" \
  --build-config=deploy/deploy_gotip.json \
  --repo-type="CLOUD_SOURCE_REPOSITORIES" \
  --revision="refs/heads/master" \
  --repo-uri="https://source.developers.google.com/p/golang-org/r/playground" \
  --name "playground-deploy-gotip-playground" \
  --description="Deploy gotip playground daily"

For golang/go#48517

Change-Id: I9d58e5a81ae4d590e6492c07cc71806864838c81
Reviewed-on: https://go-review.googlesource.com/c/playground/+/366634
Trust: Alexander Rakoczy <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
8 participants
@toothrot @beoran @ianlancetaylor @changkun @griesemer @gopherbot @seankhliao @findleyr