Skip to content

go/types, types2: gopls crash in recordTypeAndValue [1.18 backport] #51665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 14, 2022 · 3 comments
Closed

go/types, types2: gopls crash in recordTypeAndValue [1.18 backport] #51665

gopherbot opened this issue Mar 14, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.1

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #51658 to be considered for backport to the next 1.18 minor release.

@gopherbot please backport this to 1.18, it's a deterministic panic.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 14, 2022
@gopherbot gopherbot mentioned this issue Mar 14, 2022
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/392577 mentions this issue: [release-branch.go1.18] go/types, types2: use correct underlying type in union set computation

@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 15, 2022
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Mar 23, 2022
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 23, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 9d73848 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 4, 2022
@griesemer @cherrymui
[release-branch.go1.18] go/types, types2: use correct underlying type…
9d73848 
… in union set computation

Fixes #51665.

Change-Id: Ibf415d7e12849b8f50b58d74713613d4e65bc347
Reviewed-on: https://go-review.googlesource.com/c/go/+/392575
Trust: Robert Griesemer <[email protected]>
Run-TryBot: Robert Griesemer <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/392577
TryBot-Result: Gopher Robot <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.1
Development

No branches or pull requests
2 participants
@toothrot @gopherbot