-
Notifications
You must be signed in to change notification settings - Fork 18k
proposal: hash: permit usage of encoding/binary package #55104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think this needs to be a proposal. At the end of the day, the reason why we can't use |
This proposal has been added to the active column of the proposals project |
As Joe noted, this is not something we can do. |
Based on the discussion above, this proposal seems like a likely decline. |
No change in consensus, so declined. |
In the pull request #55068 it turned out that the package hash must not depend on encoding/binary.
In my opinion, if this was allowed, the code would be cleaner (I recommend to see the proposed changes in the PR) and the practical difference would not be much, since encoding/binary has little code in it that does what is needed.
Furthermore, this package is already used as a replacement for the append/put uint32/64 functions in the crypto package.
I therefore propose to allow the use of encoding/binary also in the hash package and avoid code duplication.
The text was updated successfully, but these errors were encountered: